SelwynAng / pe

0 stars 0 forks source link

Unspecific error message for duplicate phone number #2

Open SelwynAng opened 9 months ago

SelwynAng commented 9 months ago

Screenshot 2023-11-17 at 4.24.45 PM.png

When adding another person with a duplicate phone number into the application, the error message shown is unspecific and only states that "This applicant already exists in the applicant book". I personally think that the error message shown to the user should be more specific, as the users will then know exactly why they cannot add the person into the application. The original error message shown does not highlight the fact that there was a duplicate phone number.

Steps to reproduce:

  1. add n/John Doe hp/1234567 e/example@gmail.com p/Software Engineer/tester
  2. add n/Jane Doe hp/1234567 e/example1@gmail.com p/Cyber Specialist
nus-se-bot commented 9 months ago

Team's Response

Considering that the UG has highlighted how duplicate applicants are defined:

image.png

We feel that the user would be able to find which duplicate applicant is clashing with the new applicant being added.

However, we acknowledge that a more specific error message that specifies the cause of duplication would be more helpful. This is a suboptimal design of the feature, and we argue that it is not in scope, as rectifying it is less important than the work already done. Since we already have graceful error messages in place, and the software does not crash, this bug is not in scope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]