SelwynAng / pe

0 stars 0 forks source link

Wrong error message for unknown prefix #4

Open SelwynAng opened 9 months ago

SelwynAng commented 9 months ago

Screenshot 2023-11-17 at 4.48.49 PM.png

Upon adding an unknown prefix into the input for the add command, the error message shown is for the previous prefix and does not reflect that an unknown prefix has been accidentally added into the user commands.

Steps to reproduce

  1. add n/test hp/2345678 e/examplea@gmail.com d/1234 p/tester

In this case, an unknown prefix called d/ has been added into the user input, but the error message shown is that of the email prefix. Perhaps, the command parser needs to handle such cases of unknown prefixes.

soc-se-bot commented 9 months ago

Team's Response

The add command expects only the n/, hp/, e/ and p/ prefixes as stated in the UG:

image.png

As such, the expression examplea@gmail.com d/1234 was read as the input for the email parameter, which is an invalid email input.

We argue that this is a suboptimal design of a feature, but rectifying it is less important than the work that has already been done. Since an error message is gracefully thrown about the email parameter, and the user is able to continue using the software - this should be classified as not in scope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]