SelwynAng / pe

0 stars 0 forks source link

Wrong error message for `editi` command #5

Open SelwynAng opened 11 months ago

SelwynAng commented 11 months ago

Screenshot 2023-11-17 at 5.00.55 PM.pngScreenshot 2023-11-17 at 5.00.55 PM

When editing the interview details of a specific person using the editi command and unknown prefix is added into the user input, the error message shown is wrong. The error message states that the previous prefix is wrong when the error message should show that an unknown prefix has been added.

Steps to reproduce:

  1. editi 1 i/1 r/9.5 d/123

In this example, when an unknown d/ prefix is added, the error message shown is "Rating should be a number between 0.0 and 10.0 to 1 decimal place", when the error message should state that an unknown prefix has been added.

nus-se-script commented 10 months ago

Team's Response

The editi command expects only the i/, t/ and r/ prefixes as stated in the UG:

image.png

As such, the expression 9.5 d/123 was read as the input for the rating parameter, which is an invalid rating input.

We argue that this is a suboptimal design of a feature, but rectifying it is less important than the work that has already been done. Since an error message is gracefully thrown about the rating parameter, and the user is able to continue using the software - this should be classified as not in scope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]