Closed Shoooooon closed 9 months ago
I am, in general, fine with this PR - looks good to me.
I do want to be a bit pedantic about naming on the JSON format changes.
sortKind
and sortParams
should just be kind
and params
. We're already inside of a sort object, so it's redundant to have sort
in the name! In most places it's used, it will be as a parameter called sort:
or returnSort:
or similar.kind
? The SMT-LIB docs seem to mostly call it the "sort symbol", and we use "name" and "id" in other similar places. It's fine if you have a justification, but just want to be intentional about it. It will be difficult to change in the future :)