search

SemRoCo / giskard_core

This package provides the core C++ library of giskard, a constraint and optimization-based framework for robot motion control.
GNU General Public License v2.0
1 stars 8 forks source link

Fix for GitHub issue #21 #31

Closed ARoefer closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #31 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   51.42%   51.42%           
=======================================
  Files           6        6           
  Lines         704      704           
  Branches       46       46           
=======================================
  Hits          362      362           
  Misses        342      342

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a48ca00...e157123. Read the comment docs.

airballking commented 7 years ago

@ARoefer thank you for this pull request! Now I understand the solution you described in the original issue discussion. ;)

To be honest, the suggested fix does not completely convince me. While reviewing it, I also that it might be better to introduce a new type of specification, i.e. AliasReference, that comes with its own parsing and generation method. I'll give it a shot today and will keep you posted.

airballking commented 7 years ago

Fixed by semroco/giskard_core#33