search

SemRoCo / giskard_core

This package provides the core C++ library of giskard, a constraint and optimization-based framework for robot motion control.
GNU General Public License v2.0
1 stars 8 forks source link

Fix issue 21 #33

Closed airballking closed 7 years ago

airballking commented 7 years ago

Fixes SemRoCo/giskard_core#21. Replaces PR SemRoCo/giskard_core#31

Introduces a new type expression specification: AliasReferenceSpec that comes with its own representation, parsing, and generation. Also supports indefinitely long chains of alias references. @ARoefer what do you think?

codecov-io commented 7 years ago

Codecov Report

Merging #33 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   51.42%   51.42%           
=======================================
  Files           6        6           
  Lines         704      704           
  Branches       46       46           
=======================================
  Hits          362      362           
  Misses        342      342

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a48ca00...79b304c. Read the comment docs.

ARoefer commented 7 years ago

This solution is a lot cleaner. However I'm surprised that the yaml parser works. I've left a comment on yaml_parser.hpp describing why.

airballking commented 7 years ago

Thanks for the review! Unless you have further comments, I will merge tomorrow morning.