Semalab / developer-skills-matrix-discord-bot

This is a bot that allows you to assess your skills with our developer rubric directly on discord

GNU Affero General Public License v3.0

11 stars 7 forks source link

Updated the readme.md #16

Closed AnujSsStw closed 2 years ago

AnujSsStw commented 2 years ago

Pull Request

Description: Updated the readme file so that new contributors can get to know the project and how it's works

Related Issue: #15

AnujSsStw commented 2 years ago

The readme file LGTM. But the logo is white. You need to fix that.

__ Summary: 🛠️ This code needs a fix

As I mentioned above The logo renders fine but when open separately it's become very white https://github.com/Semalab/developer-rubric-discord-bot/pull/16#discussion_r901367323

kaiwalyakoparkar commented 2 years ago

@AnujSsStw Did you test this readme in light mode? If yes then could you please attach both the dark and light version images in the description of this pr.

__ Summary: :question: I have a question

AnujSsStw commented 2 years ago

@AnujSsStw Did you test this readme in light mode? If yes then could you please attach both the dark and light version images in the description of this pr.

__ Summary: ❓ I have a question

oh, heck no even IDK when was the last time I used the light mode in anything. And about the logo for light mode, I currently don't have a good logo that looks good for both cases.

AnujSsStw commented 2 years ago

hey @kaiwalyakoparkar how about this logo

kaiwalyakoparkar commented 2 years ago

hey @kaiwalyakoparkar how about this logo

Yup I think this should work :)