Closed m0t0r closed 9 years ago
@caitp how does it look like so far ?
the implementation basically looks okay to me, room for a few improvements, but mostly just nits
you can certainly merge this whenever you like, if you want to, adding helpers to the test suite to make it a bit easier to write tests is something you can do later (or not), if you like.
LGTM
I haven't added any accessibility stuff, that matters as I understood from the first directives, will add that part also and then good to go for merge :+1:
+1
@caitp Can we land this and then improve the accessibility stuff ? I am finishing one project and hope to get more free time.
yes, lgtm, merge at will =)
Status: Work in progress Based on #5