search

Semantic-Org / Semantic-UI-Angular

Semantic UI Angular Integrations
MIT License
557 stars 117 forks source link

WIP: smRadioGroup and smRadioButton directives #10

Closed m0t0r closed 9 years ago

m0t0r commented 9 years ago

Status: Work in progress Based on #5

m0t0r commented 9 years ago

@caitp how does it look like so far ?

caitp commented 9 years ago

the implementation basically looks okay to me, room for a few improvements, but mostly just nits

caitp commented 9 years ago

you can certainly merge this whenever you like, if you want to, adding helpers to the test suite to make it a bit easier to write tests is something you can do later (or not), if you like.

LGTM

m0t0r commented 9 years ago

I haven't added any accessibility stuff, that matters as I understood from the first directives, will add that part also and then good to go for merge :+1:

caitp commented 9 years ago

+1

m0t0r commented 9 years ago

@caitp Can we land this and then improve the accessibility stuff ? I am finishing one project and hope to get more free time.

caitp commented 9 years ago

yes, lgtm, merge at will =)