Closed stevenkampen closed 9 years ago
@m0t0r @caitp Ok, I've made those improvements, except for the transclusion issue. I'd like to understand a bit more about the implications before taking a stab in the dark.
@caitp Re-added ngModel
. @m0t0r FYI.
@m0t0r FYI
sorry, missed the last email. if I don't answer in a day, feel free to ping me or find me on freenode.
@caitp Tests added.
awesome, looks pretty good to me
lgtm, I'll leave it up to @m0t0r to check it in, he might have a few last comments for you.
LGTM. Just a small thing, I can land it
@m0t0r Removed.
Great job @stevesherrie. Thanks. Landing your first directive
hey @steven-ks, I am sorry but I could not find any way to reach you out. Are you still willing to contribute to this project ? Ping me on gitter. Thanks
@m0t0r Sure. I haven't been following too much, but I've noticed this little revival, and if we're putting in a concerted effort, I think I can help out.
@steven-ks great!, please ping me on gitter
@m0t0r @caitp Please review. Just starting with something simple so I can get aligned with project style and convention. Any feedback on best practices for performance (VM optimizations) would be heeded well.
Regarding checkboxes, I'm wondering, should they somehow share logic with radio buttons (radio groups can use a checkbox style, etc)?
Some general questions that I have are: