[WIP] Semantic-UI-Angular buttons - Githubissues

Semantic-Org / Semantic-UI-Angular

Semantic UI Angular Integrations

MIT License

557 stars 117 forks source link

[WIP] Semantic-UI-Angular buttons #3

Closed m0t0r closed 9 years ago

m0t0r commented 9 years ago

WIP: I have made initial design for buttons element. Currently I've created radio button directive, checkbox is coming. As Semantic-UI has "Elements", "Conditionals", "Modules", etc. I decided to group directives following that pattern (e.g. angular module for buttons look like 'semantic.ui.elements.button').

@caitp please take a look at it and I have a few questions:

Which prefix should we use ? I used "sem-" as you mentioned in 'old' repo.
Semantic-UI has "Conditionals" buttons, should it be as a special case with its directive or we take it as normal radio button?

caitp commented 9 years ago

I don't have much of an opinion on attribute prefixes (maybe @jlukic has a preference for branding purposes?) --- but I think we should learn some lessons from the original implementation. There are some comments up there