Closed mxth closed 8 years ago
@caitp @m0t0r please have a look at it
the code itself looks okay, just need to try it out
I'm not able to check out the patch :( git complains it was split wrong
ok, so the pr itself doesn't look totally done yet ---
--- the demo doesn't work very well. Can we clean this up before merging it in?
@caitp It looks fine on my home machine (win 8.1 with IE 11, Chrome 44, FF 39). Can I have some debug info?
ok, how exactly are you running the demos? is there a grunt task added?
I use http-server
to serve the files. In base dir, type http-server
then navigate to http://localhost:8081/src/elements/embed/demo/
@caitp have you got it running yet?
I ran it through http-server but couldn't make it work sorry
Continuing work of #18: update for SU 2.0, add support for any embed content and fix some issues from the last PR.