search

Semantic-Org / Semantic-UI-Angular

Semantic UI Angular Integrations
MIT License
557 stars 117 forks source link

feat(embed): add embed directive #30

Closed mxth closed 8 years ago

mxth commented 9 years ago

Continuing work of #18: update for SU 2.0, add support for any embed content and fix some issues from the last PR.

mxth commented 9 years ago

@caitp @m0t0r please have a look at it

caitp commented 9 years ago

the code itself looks okay, just need to try it out

caitp commented 9 years ago

I'm not able to check out the patch :( git complains it was split wrong

caitp commented 9 years ago

ok, so the pr itself doesn't look totally done yet --- screen shot 2015-07-29 at 8 55 20 am --- the demo doesn't work very well. Can we clean this up before merging it in?

mxth commented 9 years ago

@caitp It looks fine on my home machine (win 8.1 with IE 11, Chrome 44, FF 39). Can I have some debug info?

caitp commented 9 years ago

ok, how exactly are you running the demos? is there a grunt task added?

mxth commented 9 years ago

I use http-server to serve the files. In base dir, type http-server then navigate to http://localhost:8081/src/elements/embed/demo/

mxth commented 9 years ago

@caitp have you got it running yet?

caitp commented 9 years ago

I ran it through http-server but couldn't make it work sorry