Semantic-Org / Semantic-UI-Angular

Semantic UI Angular Integrations
MIT License
557 stars 117 forks source link

Changed jshint to eslint #36

Closed matheuspoleza closed 8 years ago

matheuspoleza commented 8 years ago

We want to change to es6 with angular 1.4, so to do that its better to use eslint. It include es6 features and its a better lint solution.

Notes:

@caitp @m0t0r

caitp commented 8 years ago

Nah, -1 from me on this one

matheuspoleza commented 8 years ago

@caitp why?

caitp commented 8 years ago

jshint supports es6 just fine, and most of the code changes here look totally bogus. Deleting comments and shit like that, not a good scene

matheuspoleza commented 8 years ago

@caitp about the comments i returned that, its not necessary. But other changes was about uggly indent and max-len. And about es6, doesnt support yet, where I know.

I made this change because I talked to @m0t0r about this. And he talked to do this change

caitp commented 8 years ago

Jshint absolutely does support es6 features, where are you getting that it doesn't?

matheuspoleza commented 8 years ago

my mistake about "doesn't support", but reading the docs I didn't see anything like this in jshint: selection_214

Eslint has specific features to es6

caitp commented 8 years ago

You can't enable specific es6 features, you get them all as a package. This is fine, and really doesn't matter. Just set "esversion" to 6