Semantic-UI-Angular: sm-button directive

Semantic-Org / Semantic-UI-Angular

Semantic UI Angular Integrations

MIT License

557 stars 117 forks source link

Semantic-UI-Angular: sm-button directive #4

Closed m0t0r closed 9 years ago

m0t0r commented 9 years ago

WIP: sm-button is a generic button directive. I took as a base idea the design from angular-material.

A few thing to note:

I have created a service (ariaHelper) to check if an element has aria specific attribute.
Currently I've decided to use "sm-" prefix. I liked it more than "sem-".
Unit tests are coming.

@caitp reconsidered design and second attempt :)

m0t0r commented 9 years ago

@caitp I have updated this PR and added unit tests, please take a look again.

caitp commented 9 years ago

basically looks okay, few nits here and there

caitp commented 9 years ago

Note that using textContent limits browser support, so no legacy IE --- but that's probably not a problem. Even so, we have jquery elements, and are allowed to use them.

caitp commented 9 years ago

oh, go ahead and land whenever you want, the other comments arent really blockers for this. nit: these arent chore commits, these are features (feat) and tests (test) and refactors (refactor) commits