search

Semantic-Org / Semantic-UI-Angular

Semantic UI Angular Integrations
MIT License
557 stars 117 forks source link

Refactor divider component #52

Closed frankadrian closed 8 years ago

frankadrian commented 8 years ago

This is the first time im working with TS. Please point out things I can improve. I mainly copied from the button element. Implements #43

m0t0r commented 8 years ago

@frankadrian thanks for your PR, though we are still preparing environment for community contributions. Please remove demo folder and .js files from your PR and squash your commits into one.

frankadrian commented 8 years ago

@m0t0r, sure done.

m0t0r commented 8 years ago

@frankadrian LGTM, just one thing. Please change commit message to follow conventional-changelog

refactor(elements): Refactor sm-divider component to TS

would work

m0t0r commented 8 years ago

@frankadrian there is a conflict with last merge to master, could you please resolve it and I will merge your PR.

frankadrian commented 8 years ago

@m0t0r sure, base is up to date.