WIP: sm-card component - Githubissues

Semantic-Org / Semantic-UI-Angular

Semantic UI Angular Integrations

MIT License

557 stars 117 forks source link

WIP: sm-card component #53

Open m0t0r opened 8 years ago

m0t0r commented 8 years ago

This PR includes a couple of additional things:

Helper functions for DOM manipulations
ComponentDirective class for code reuse
Basic directive for right floated elements

TODO:

[ ] unit tests
[ ] documentation
[ ] check support of all use cases as for original component

@mxth @HackedByChinese please review

moribvndvs commented 8 years ago

The helper base class seems like a nice start. I don't have any real feedback until we start utilizing it heavily against a variety of components and see where it is lacking. Let's see some unit tests though. Do we have any plans for unit tests vs e2e testing?

m0t0r commented 8 years ago

Yes, eventually we will have both test strategies: unit tests and E2E tests.