Closed m0t0r closed 9 years ago
looks okay to me --- might want to also add a case for the grid divider option
Well, as I see for the grid case they actually have it on the grid itself as ui divided grid
. I am not sure how it could be also considered on this directive?
Beats me ;) I think it's fine, although it seems like it might not be worth pushing through the compile process for such a minor component
The reason is when divider has just ui divider
classes it does not format internal content such as word "or" or something, it does when it has actual classes either vertical
or hortizontal
so that we can write
<sm-divider vertical>Or</sm-divider>
instead of
<sm-divider class="vertical">Or</sm-divider>
What do you think is it worth to compile or native class style is better ?
Making it a directive means you're compiling regardless
Oh, I did not understand what exactly you ment. Well, I took a look at material design and they actually have it as a directive. let's keep it as a directive for a while?
@caitp please take a look at this pretty simple directive