Semantic-Org / Semantic-UI-CSS

CSS Only distribution
http://www.semantic-ui.com
MIT License
489 stars 360 forks source link

Remove extra semi-colon from step.css also #77

Closed sahi1422 closed 2 years ago

sahi1422 commented 2 years ago

@jlukic @levithomason , I forgot to remove the semi-colon from the step.css

https://github.com/Semantic-Org/Semantic-UI-CSS/pull/76

ajohnston1219 commented 2 years ago

Is there a reason this is still open? I can confirm this is the same exact edit I have to do to get it working with webpack 5.

R3DST0RM commented 2 years ago

Are there any updates on why this isn't merged yet?

guslen commented 2 years ago

@fniessink or maybe @peacekeeper or @sahi1422 ? Also, a version bump would be awesome, @sahi1422

guslen commented 2 years ago

@jlukic will you merge this? Also, a version bump would be excellent. 😄

guslen commented 2 years ago

@peacekeeper, do you know who can merge this pull request?

peacekeeper commented 2 years ago

Sorry I don't know.. I also wish this could be merged.

guslen commented 2 years ago

@peacekeeper

Sorry I don't know.. I also wish this could be merged.

I sent an email to info@semantic-ui.com with this content: Subject:

Who can merge PR in Semantic css

Content:

Hi, We need a merge and a version bump for semantic-ui-css. jlucik @jlukic doesn't seem to react even after tagging him. I don't know who is in charge of the repo. this is the PR in question https://github.com/Semantic-Org/Semantic-UI-CSS/pull/77#issue-1083335401

Thank you for the help.

Best regards, Gustav Lennart Voigt

jlukic commented 2 years ago

These repos are automatically generated from the main Semantic UI repo with a release bot.

You will need to make any PR requests off the main repo src/ folder if there's a typo.

You can find the correct file here https://github.com/Semantic-Org/Semantic-UI/blob/master/src/themes/default/elements/step.overrides#L5

jlukic commented 2 years ago

I've gone ahead and run the release bot to publish the changes from the main repo @sahi1422