Semantic-Org / Semantic-UI-React

The official Semantic-UI-React integration
https://react.semantic-ui.com
MIT License
13.23k stars 4.05k forks source link

Sticky: Sticky content that is larger than the viewport does not automatically scroll independently from the context #2372

Open onoufriosm opened 6 years ago

onoufriosm commented 6 years ago

Steps

• Go to: https://react.semantic-ui.com/modules/sticky#sticky-example-oversized • Scroll

Expected Result

Left column scrolls independently from the context

Actual Result

Left column scrolls only when the end of the context (centered column) is reached

Version

0.77.1

Testcase

https://react.semantic-ui.com/modules/sticky#sticky-example-oversized


Works as expected on https://semantic-ui.com/modules/sticky.html

levithomason commented 6 years ago

Thanks for the complete report. It seems Sticky is assuming the content should stick to the top of the viewport and not accounting for oversized content.

Also, the description in our doc example should be updated. It is missing crucial info about this feature:

Sticky content that is larger than the viewport.

Should read:

Sticky content that is larger than the viewport will automatically scroll independently from the context, shifting scroll direction at any time will also immediately adjust the scroll position of the fixed content.

cyrielo commented 6 years ago

did this issue get fixed?

asifsomy commented 6 years ago

Is this bug fixed? Long Stuck Content behaves differently in react version as compared to jquery version. I think jquery one is more correct.

brianespinosa commented 6 years ago

@cyrielo @asifsomy This report is tagged as help wanted and looking at the history above, nobody has linked any pull requests here. That means it is still an open issue and either of you are more than welcome to submit a pull request to solve it.

stale[bot] commented 6 years ago

There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

stale[bot] commented 5 years ago

This issue will be closed due to lack of activity for 12 months. If you’d like this to be reopened, just leave a comment; we do monitor them!

stale[bot] commented 5 years ago

There has been no activity in this thread for 180 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

jjylha commented 4 years ago

Please fix. 🙏 Oversized SUI-R Sticky is pretty useless with this bug :/