search

Semantic-Org / Semantic-UI-React

The official Semantic-UI-React integration
https://react.semantic-ui.com
MIT License
13.22k stars 4.05k forks source link

Input: lang prop #2979

Closed foysalit closed 6 years ago

foysalit commented 6 years ago

Feature Request

As of now, <Input lang="fr"/> will add lang="fr" on the wrapping div element instead of the input element itself. It would be great if we could set the lang prop to input elements for localization purposes.

Proposed solution

I can implement the additional property and submit a PR if someone from the team can point me in the right direction. Will it work if I just add the lang prop in this file: https://github.com/Semantic-Org/Semantic-UI-React/blob/master/src/elements/Input/Input.d.ts ?

welcome[bot] commented 6 years ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

layershifter commented 6 years ago

We have special htmlPropsUtils for these case. We just need to add a new value there.

Feel free to open PR 👍