Icon for the selected option is not shown in selection Dropdowns

mfen commented 2 years ago

Bug Report

Steps

Create a <Dropdown selection /> with icon set in the options.
Select an option (or pass in a controlled selected value).

Expected Result

The icon for the selected option should be displayed to the left of the Dropdown text, similar to how it is shown in the dropdown menu items or how the Flag or Image for a selected option is shown.

Actual Result

No icon is shown for the selected option in the collapsed Dropdown, only the option's text is shown.

Version

2.1.2

Testcase

https://codesandbox.io/s/semantic-ui-react-forked-g2lci9

This is essentially the same issue as #1147, but that issue seems to have been mistakenly closed with #4003. While the original #3980 had included support for Icons alongside Flags and Images, the code for Icon support was omitted in this eventual commit of #4003 (@layershifter).

welcome[bot] commented 2 years ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

Fox32 commented 2 years ago

Just came along the same issue today, so I created #4347

Fox32 commented 2 years ago

Btw, there is a possible workaround:

You can extend the option text to include the icon:

    {
      key: 'my-user',
      text: (
        <>
          <Icon name="user" />
          My User
        </>
      ),
      searchText: 'My User',
      value: 'my-user',
    },

However, this breaks search. That's why I added a custom searchText field in the option and included custom search function in the <Dropdown>:

<Dropdown
options={options}
search={(options, query) => {
const re = new RegExp(escapeRegExp(query), 'i');
return options.filter((opt) => re.test(opt.searchText));
}}
…

This is cumbersome, but an option for everyone that can't wait for a fix :wink:.

Semantic-Org / Semantic-UI-React