Semantic-Org / Semantic-UI-React

The official Semantic-UI-React integration
https://react.semantic-ui.com
MIT License
13.23k stars 4.05k forks source link

No Tik Tok logo for the Icons component #4353

Open colinpcurtis opened 2 years ago

colinpcurtis commented 2 years ago

Feature Request

Problem description

The Icons component provides many logos of common social media platforms, and I was trying to add a Tik Tok icon to link to our website, but no such icon exists. It would make sense to add this icon because many people rely on Tik Tok as a social media platform and may wish to link to their account through Semantic-UI-React Icons.

Proposed solution

I tried looking through the code and found the Icon component definition, however I'm not sure where the exact logos for the icons exist, however all that likely needs to be updated is to add a Tik Tok logo. If there's graphic design involved then I wouldn't be able to implement the solution, however if the Icon component just fetches the logo from another website then I'd be able to add this feature.

I can't see any obvious drawbacks since this is just extending some functionality.

MVP

Users should be able to specify the name prop as tik-tok of the Icon component see the Tik Tok logo.

welcome[bot] commented 2 years ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

maddox05 commented 1 week ago

^^

whitebyte commented 1 week ago

This is becauise SUIR uses an outdated version of FontAwesome. As a temporary workaround you can fallback to <i class="fa-brands fa-tiktok"></i>

maddox05 commented 1 week ago

This is becauise SUIR uses an outdated version of FontAwesome. As a temporary workaround you can fallback to <i class="fa-brands fa-tiktok"></i> that does not seem to work, is there anything that I would need installed to do that?