Closed timduffin closed 1 year ago
💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:
yarn lint
locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.yarn test
locally to catch errors. This ensures all components still behave as they should.yarn start
to run the doc site locally and try a few pages, ensuring everything is in good working order.We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
Nice wanted to sort this out as well.
The powers that be need to update Vercel's node build version
Error: Node.js Version "12.x" is discontinued and must be upgraded. Please set Node.js Version to 16.x in your Project Settings to use Node.js 16.
The powers that be need to update Vercel's node build version
- https://github.com/Semantic-Org/Semantic-UI-React/deployments/activity_log?environment=Preview
- https://vercel.com/semantic-ui/semantic-ui-react/CdK9aoNtf5YT8rghLEU3HeLueji6
Error: Node.js Version "12.x" is discontinued and must be upgraded. Please set Node.js Version to 16.x in your Project Settings to use Node.js 16.
Done 👍 Will check the PR a bit later this week.
@timduffin thank you 👍
Congrats on merging your first pull request! 🎉🎉🎉
Could we release this fix?
@quanganhtran was released in semantic-ui-react@2.1.4
.
typescript@4.8.4
build errorFor completeness, here is the breaking change in question https://devblogs.microsoft.com/typescript/announcing-typescript-4-8-beta/#breaking-changes