Semantic-Org / Semantic-UI-React

The official Semantic-UI-React integration
https://react.semantic-ui.com
MIT License
13.2k stars 4.04k forks source link

fix(types): Update SemanticShorthandCollection to support Typescript 4.8 #4390

Closed timduffin closed 1 year ago

timduffin commented 1 year ago

typescript@4.8.4 build error

73 export type SemanticShorthandCollection<TProps> = SemanticShorthandItem<TProps>[]
                                               ~~~~~~
    This type parameter might need an `extends Record<string, any>` constraint.

For completeness, here is the breaking change in question https://devblogs.microsoft.com/typescript/announcing-typescript-4-8-beta/#breaking-changes

welcome[bot] commented 1 year ago

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

iamtomcat commented 1 year ago

Nice wanted to sort this out as well.

timduffin commented 1 year ago

The powers that be need to update Vercel's node build version

layershifter commented 1 year ago

The powers that be need to update Vercel's node build version

Error: Node.js Version "12.x" is discontinued and must be upgraded. Please set Node.js Version to 16.x in your Project Settings to use Node.js 16.

Done 👍 Will check the PR a bit later this week.

layershifter commented 1 year ago

@timduffin thank you 👍

welcome[bot] commented 1 year ago

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

quanganhtran commented 1 year ago

Could we release this fix?

layershifter commented 1 year ago

@quanganhtran was released in semantic-ui-react@2.1.4.