Semantic-Org / Semantic-UI-React

The official Semantic-UI-React integration
https://react.semantic-ui.com
MIT License
13.2k stars 4.04k forks source link

TypeScript version 4.8.4 Tprops error #4391

Closed timduffin closed 1 year ago

timduffin commented 1 year ago

Bug Report

Type fails build with typescript@4.8.4.

Opened a pr here https://github.com/Semantic-Org/Semantic-UI-React/pull/4390

Steps

npm / yarn / pnpm build

Expected Result

built

Actual Result

73 export type SemanticShorthandCollection<TProps> = SemanticShorthandItem<TProps>[]
                                               ~~~~~~
    This type parameter might need an `extends Record<string, any>` constraint.

Version

semantic-ui-react@2.1.3

welcome[bot] commented 1 year ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

layershifter commented 1 year ago

Fixed by #4390