search

Semantic-Org / Semantic-UI-React

The official Semantic-UI-React integration
https://react.semantic-ui.com
MIT License
13.2k stars 4.04k forks source link

Menu Item Keyboard Accessibility #4393

Closed kiachoi closed 11 months ago

kiachoi commented 1 year ago

Menu Item Accessibility

Any feedback will be appreciated πŸ’—

Relates to Issue #4384

  1. Added tabIndex on MenuItem component for accessibility
  2. Added onKeyPress to handle on Enter & Space selection for accessibility
  3. Added additional test coverage for MenuItem-test.js

Testing: Can test on Tab element Can test disabled functionality on Menu element

Limitations: Another issue should be created if there isn't one already for:

codecov-commenter commented 1 year ago

Codecov Report

Base: 99.75% // Head: 99.75% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (7a5db25) compared to base (c3cbcae). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4393 +/- ## ======================================= Coverage 99.75% 99.75% ======================================= Files 180 180 Lines 3248 3255 +7 ======================================= + Hits 3240 3247 +7 Misses 8 8 ``` | [Impacted Files](https://codecov.io/gh/Semantic-Org/Semantic-UI-React/pull/4393?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Semantic-Org) | Coverage Ξ” | | |---|---|---| | [src/collections/Menu/MenuItem.js](https://codecov.io/gh/Semantic-Org/Semantic-UI-React/pull/4393/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Semantic-Org#diff-c3JjL2NvbGxlY3Rpb25zL01lbnUvTWVudUl0ZW0uanM=) | `100.00% <100.00%> (ΓΈ)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Semantic-Org). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Semantic-Org)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.