Semantic-Org / Semantic-UI-React

The official Semantic-UI-React integration
https://react.semantic-ui.com
MIT License
13.2k stars 4.04k forks source link

fix(Input): pass focus options #4398

Closed meltyshev closed 1 year ago

meltyshev commented 1 year ago

According to https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/focus the focus method can have an options parameter, which is useful, for example, to prevent scrolling. With this fix, options parameter is passed to the referenced DOM element.

welcome[bot] commented 1 year ago

πŸ’– Thanks for opening this pull request! πŸ’–

Here is a list of things that will help get it across the finish line:

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

codecov-commenter commented 1 year ago

Codecov Report

Base: 99.75% // Head: 99.75% // No change to project coverage :thumbsup:

Coverage data is based on head (95859f2) compared to base (be9c744). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4398 +/- ## ======================================= Coverage 99.75% 99.75% ======================================= Files 180 180 Lines 3248 3248 ======================================= Hits 3240 3240 Misses 8 8 ``` | [Impacted Files](https://codecov.io/gh/Semantic-Org/Semantic-UI-React/pull/4398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Semantic-Org) | Coverage Ξ” | | |---|---|---| | [src/elements/Input/Input.js](https://codecov.io/gh/Semantic-Org/Semantic-UI-React/pull/4398/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Semantic-Org#diff-c3JjL2VsZW1lbnRzL0lucHV0L0lucHV0Lmpz) | `100.00% <100.00%> (ΓΈ)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Semantic-Org). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Semantic-Org)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.