Closed naman1608 closed 10 months ago
π Thanks for opening this pull request! π
Here is a list of things that will help get it across the finish line:
yarn lint
locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.yarn test
locally to catch errors. This ensures all components still behave as they should.yarn start
to run the doc site locally and try a few pages, ensuring everything is in good working order.We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
Patch coverage: 100.00%
and no project coverage change.
Comparison is base (
7d3e162
) 99.51% compared to head (bb8d39d
) 99.51%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Could anyone help with why the Vercel deployment is failing?
Could anyone help with why the Vercel deployment is failing?
https://vercel.com/semantic-ui/semantic-ui-react/2rsf2GtY7HLtJkrukYAvzAAMpkEz
https://vercel.com/semantic-ui/semantic-ui-react/FjCWFAo6wewW72a5e2QHf3jL8wCA
Going through the logs of these deployments indicates that bumping the node version from 14 to 18 has been long due. The build logs clearly say that builds after 15 Aug 2023 will fail.
@naman1608 @VaibhavMalik4187 thanks for heads up. I changed Node version in settings, all good now π’ I also added a test, so we are good to merge π
Congrats on merging your first pull request! πππ
Fixes #4435