Semantic-Org / Semantic-UI-React

The official Semantic-UI-React integration
https://react.semantic-ui.com
MIT License
13.2k stars 4.04k forks source link

feat(Form.Group): add disabled prop #4436

Closed naman1608 closed 10 months ago

naman1608 commented 10 months ago

Fixes #4435

welcome[bot] commented 10 months ago

πŸ’– Thanks for opening this pull request! πŸ’–

Here is a list of things that will help get it across the finish line:

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7d3e162) 99.51% compared to head (bb8d39d) 99.51%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4436 +/- ## ======================================= Coverage 99.51% 99.51% ======================================= Files 186 186 Lines 3511 3511 ======================================= Hits 3494 3494 Misses 17 17 ``` | [Files Changed](https://app.codecov.io/gh/Semantic-Org/Semantic-UI-React/pull/4436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Semantic-Org) | Coverage Ξ” | | |---|---|---| | [src/collections/Form/FormGroup.js](https://app.codecov.io/gh/Semantic-Org/Semantic-UI-React/pull/4436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Semantic-Org#diff-c3JjL2NvbGxlY3Rpb25zL0Zvcm0vRm9ybUdyb3VwLmpz) | `100.00% <100.00%> (ΓΈ)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

naman1608 commented 10 months ago

Could anyone help with why the Vercel deployment is failing?

VaibhavMalik4187 commented 10 months ago

Could anyone help with why the Vercel deployment is failing?

https://vercel.com/semantic-ui/semantic-ui-react/2rsf2GtY7HLtJkrukYAvzAAMpkEz

https://vercel.com/semantic-ui/semantic-ui-react/FjCWFAo6wewW72a5e2QHf3jL8wCA

Going through the logs of these deployments indicates that bumping the node version from 14 to 18 has been long due. The build logs clearly say that builds after 15 Aug 2023 will fail.

layershifter commented 10 months ago

@naman1608 @VaibhavMalik4187 thanks for heads up. I changed Node version in settings, all good now 🟒 I also added a test, so we are good to merge πŸŽ‰

welcome[bot] commented 10 months ago

Congrats on merging your first pull request! πŸŽ‰πŸŽ‰πŸŽ‰

robot victory dance