Semantic-Org / Semantic-UI-React

The official Semantic-UI-React integration
https://react.semantic-ui.com
MIT License
13.2k stars 4.04k forks source link

chore: add "use client" directive in components where it's needed #4452

Closed layershifter closed 6 months ago

layershifter commented 6 months ago

This PR fixes #4433.

⚠️ Heads up

Next.js does not support List.Item syntax i.e. ListItem works List.Item does not 💥 There is an issue related to the problem (https://github.com/vercel/next.js/issues/44389), however with current implementation I don't believe that it's solvable on their side. I will create a follow-up PR to update examples to not reference that syntax.

github-actions[bot] commented 6 months ago

size-limit report

Path Size
bundle-size/dist/Button.size.js 53.86 KB (-0.3% 🔽)
bundle-size/dist/Icon.size.js 27.34 KB (-0.06% 🔽)
bundle-size/dist/Image.size.js 49.45 KB (-0.28% 🔽)
bundle-size/dist/Modal.size.js 62.32 KB (-0.36% 🔽)
bundle-size/dist/Portal.size.js 37.12 KB (-0.21% 🔽)
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8700e57) 99.50% compared to head (7921437) 99.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4452 +/- ## ========================================== - Coverage 99.50% 99.50% -0.01% ========================================== Files 186 186 Lines 3466 3465 -1 ========================================== - Hits 3449 3448 -1 Misses 17 17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.