Pass props and other data separately into all component callbacks

Semantic-Org / Semantic-UI-React

The official Semantic-UI-React integration

https://react.semantic-ui.com

MIT License

13.19k stars 4.04k forks source link

Pass props and other data separately into all component callbacks #4465

Open skondrashov opened 4 months ago

skondrashov commented 4 months ago

Resolves #4464

All callbacks to components which need to process some internal value of the component have had to pull the data out of the object intended to mirrors the props that were passed into the component back to the parent. This PR separates those concepts, so that the callbacks receive internal values of components as separate parameters from the props object.

These are clearly breaking changes but they make the API cleaner and make it possible to see what values (including their types) the callbacks.

To make them easier to review, the changes are broken up into commits by each component which needed to be updated. All tests pass locally after every commit.

welcome[bot] commented 4 months ago

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
Run yarn test locally to catch errors. This ensures all components still behave as they should.
Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
semantic-ui-react	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 3, 2024 6:39am

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.50%. Comparing base (c579cab) to head (56418a2). Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #4465 +/- ## ========================================== - Coverage 99.50% 99.50% -0.01% ========================================== Files 186 186 Lines 3465 3464 -1 ========================================== - Hits 3448 3447 -1 Misses 17 17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

layershifter commented 4 months ago

ACK on this, I won't be able to check this in upcoming two weeks, but I will follow up later. Thx