fix: add "linkedin in" icon name to enumeration to fix console error

Semantic-Org / Semantic-UI-React

The official Semantic-UI-React integration

https://react.semantic-ui.com

MIT License

13.19k stars 4.04k forks source link

fix: add "linkedin in" icon name to enumeration to fix console error #4471

Closed mwaddell closed 4 months ago

mwaddell commented 4 months ago

fixes #4470 by adding the "linkedin in" name to the existing enumerations

welcome[bot] commented 4 months ago

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
Run yarn test locally to catch errors. This ensures all components still behave as they should.
Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
semantic-ui-react	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 11, 2024 5:29pm

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (v2.x@a32499d). Click here to learn what that means.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## v2.x #4471 +/- ## ======================================= Coverage ? 99.75% ======================================= Files ? 180 Lines ? 3249 Branches ? 0 ======================================= Hits ? 3241 Misses ? 8 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

welcome[bot] commented 4 months ago

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

layershifter commented 4 months ago

Oops, I haven't mentioned that it targets v2 branch. @mwaddell I will cherry pick commit to master branch.

mwaddell commented 4 months ago

Oops, I haven't mentioned that it targets v2 branch. @mwaddell I will cherry pick commit to master branch.

Thank you @layershifter - I identified the issue in v2.1.5 which is why I targeted that branch - we haven't migrated any of our code to target 3.x yet since it's still in beta.