chore: replace lodash invoke with optional chaining

Semantic-Org / Semantic-UI-React

The official Semantic-UI-React integration

https://react.semantic-ui.com

MIT License

13.19k stars 4.04k forks source link

chore: replace lodash invoke with optional chaining #4482

Open CrazyStevenz opened 1 month ago

CrazyStevenz commented 1 month ago

This PR takes the original work of https://github.com/Semantic-Org/Semantic-UI-React/pull/4428 and addresses the import comments, as well as some other linting errors. I used their commit directly, so they appear as the author, thus properly crediting them in my opinion.

Semantic UI React is the only package we're using that requires lodash, so I'd like to help get closer to the point where you can stop depending on it.

welcome[bot] commented 1 month ago

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
Run yarn test locally to catch errors. This ensures all components still behave as they should.
Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
semantic-ui-react	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 21, 2024 11:39pm

CrazyStevenz commented 1 month ago

I'm not sure what the type of onMouseLeave in the Rating.js component should be to satisfy the failing test.