Open stevenrick opened 1 month ago
💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:
yarn lint
locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.yarn test
locally to catch errors. This ensures all components still behave as they should.yarn start
to run the doc site locally and try a few pages, ensuring everything is in good working order.We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
semantic-ui-react | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 29, 2024 4:52pm |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.50%. Comparing base (
1623c8d
) to head (34dedbd
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
one note - i called this a feature, but it could be argued it is actually a bugfix - it's not obvious what the intended purpose of closeOnChange is but I'd argue it should be to close on ANY change (including removal) not just additions, hence this PR
Fixes #4491
This PR adds support for closeOnChange for item removal via label and backspace in a Multiple Selection Dropdown