search

Semantic-Org / Semantic-UI

Semantic is a UI component framework based around useful principles from natural language.
http://www.semantic-ui.com
MIT License
51.11k stars 4.94k forks source link

[Dropdown] Error style is incorrect when in Form > Field #5207

Open jeremyjohn opened 7 years ago

jeremyjohn commented 7 years ago

When using Dropdown inside Form > Field with error class there is a incorrect styling

Referred from semantic ui react: https://github.com/Semantic-Org/Semantic-UI-React/issues/1462 image

awgv commented 7 years ago

Hi, please provide a test case as per our contributing guidelines; you can fork this JSFiddle.

jeremyjohn commented 7 years ago

Hi, This is my fiddle results. http://jsfiddle.net/uwp6a3ux/ looks like it has something to do with the "text" class in span.

I'm not sure if it's React-SUI problem or SUI styling now, because when i opened a issue at https://github.com/Semantic-Org/Semantic-UI-React/issues/1462 they said it's SUI styling which is incorrect and asked me to open the issues here instead.

awgv commented 7 years ago

@jeremyjohn Thanks, the reason I asked for a test case, is because I couldn’t reproduce—completely forgot that dropdowns could have descriptions. I’ve read Semantic-Org/Semantic-UI-React#1462, will try to deal with it tomorrow, but it will take a while before it’s merged and published as a release, so maybe it’s a good idea to come up with a workaround until then.

stale[bot] commented 6 years ago

There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

lubber-de commented 3 years ago

Fixed in the community fork Fomantic-UI by https://github.com/fomantic/Fomantic-UI/pull/1803