search

Semantic-Org / Semantic-UI

Semantic is a UI component framework based around useful principles from natural language.
http://www.semantic-ui.com
MIT License
51.12k stars 4.94k forks source link

[Accordion] jQuery Easing plugin mentioned in accordion can easily make your life horrible #5816

Open abriginets opened 7 years ago

abriginets commented 7 years ago

Hello. I'm currently developing some projects and I'm using bundleo of jQuery + Semantic-UI. With Semantic-UI I'm using Accordion module and when I go deep into the docs, I mentioned that there's a phrase:

Easing of opening animation. EaseInOutQuint is included with accordion, for additional options you must include easing equations.

Default easing EaseInOutQuint is good enough to use it just from the box, but I've found it quite boring and I'd like to change it with jQuery Easing plugin mentioned in docs. I've downloaded it and started using my brand new easings, but I didn't mention that all of my jQuery animations are gone(e.g. .fadeIn(), .fadeOut(), .animate(), etc). After I finally give an attention to missing animations it tooks two days for me to find out what exactly is wrong.

The thing is that jQuery Easing plugin you mentioned out there is disabling all of the jQuery animations. There's no mention of this anywhere. My thought is that if you mention plugins like this then you must to warn your users what could be the consequences of using this plugin.

Much thanks in advance.

awgv commented 7 years ago

Hi @JamesJGoodwin, sorry for the delay, are you sure it’s the culprit, because I’ve tried adding jQuery Easing Plugin on top of SUI, and jQuery’s default methods like fadeOut work fine with it. Here’s the plugin’s GitHub repository, as their website seems to be hosting a version that’s a bit outdated. What jQuery version are you using?

abriginets commented 7 years ago

@Banandrew I'm sure. After I removed jQuery Easing Plugin from the page - everything was back to normal. I'm using jQuery version of 3.2.1.

awgv commented 7 years ago

@JamesJGoodwin I was able to reproduce it. jquery.easing works fine when SUI isn’t present, but I went through the framework’s source, and the accordion seems to be using it correctly. We’ll investigate.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.