Semantic-Org / Semantic-UI

Semantic is a UI component framework based around useful principles from natural language.
http://www.semantic-ui.com
MIT License
51.11k stars 4.94k forks source link

[Accordion] Incorrect behavior of accordion in accordion (not nested) #5901

Open savolkov opened 7 years ago

savolkov commented 7 years ago

Hello!

You can see the case here: https://jsfiddle.net/savolkov/xbfnvy8h/2/ When accordion in accordion is used, it leads to unexpected behaviour.

P.S. Yep, we know about nested accordions

Thanks

awgv commented 7 years ago

Linking a probably related issue: #5447.

JeremyIoThink commented 6 years ago

Hi, I face the same issue and after some search it append that it was due to my trigger selector. I've setup the title as main selector.

$(".ui.accordion").accordion({ exclusive: false, closeNested: false, selector: { trigger: ".title" } });

As the event binding use JQuery 'on' method to setup event bindings the event is fired as many times as it find '.title' under the accordion. I changed my selector to '> .title' to avoid children accordions titles and it works.

$(".ui.accordion").accordion({ exclusive: false, closeNested: false, selector: { trigger: "> .title" } });

Hope this helps.

stale[bot] commented 6 years ago

There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

lubber-de commented 5 years ago

Either don't use ui accordion for the nested accordions or initate the accordion only for the parent by selecting a unique name, then it works as expected:

$('#myparentaccordiononly') .accordion();

Fixed by removing the ui in the nested accordion https://jsfiddle.net/4erm9q0u/