Open bytasv opened 6 years ago
Hey, can you provide some code that gets you confused? jsbin/jsfiddle demo would be nice
@w96k let me give you a links to source of the variables it should be enough to see the problem:
If I went and changed the padding for Input
component, I will have to do the same for Form
Input
.
Here is the screenshot for Input
Here is the screenshot for Form
Input
Now it's really strange why it is implemented like that? Why simple input is different from the form input? And how to deal with duplication if you want to change the style or if you want to extend it?
I agree this is inconsistent. I think this was implemented to add some flexibility to theming to allow the user to change the styles for both individually.
I think we should take some input from others to see what they think before changing anything.
What I simply did for my own usecase as a temporary fix - I commented out form input declaration in forms.less
file, now it seems to be working as expected. But I think it would be great to at least make it configurable so I don't have to mess up theme main files
There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.
However, PRs for this issue will of course be accepted and welcome!
If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!
Steps
I'm using react semantic-ui but I think it's relevant to style of the framework:
Expected Result
I will be able to see restyled Input inside form
Actual Result
Input looses style because From provides it's own style for Inputs
Version
2.3.z
Why are there different styles for from inputs and standalone inputs? It seems that it forces me to duplicate restyling effort. Or is there something I don't get? This seems like a bug in the framework