search

Semantic-Org / Semantic-UI

Semantic is a UI component framework based around useful principles from natural language.
http://www.semantic-ui.com
MIT License
51.11k stars 4.94k forks source link

Update FontAwesome #6395

Open Flipez opened 6 years ago

Flipez commented 6 years ago

Currently FontAwesome 5.0.8 is implemented but since then they introduced a lot new icons.

The latest version is currently 5.0.13 (https://github.com/FortAwesome/Font-Awesome/blob/master/CHANGELOG.md)

Would be nice to see this in a new semantic release.

y0hami commented 6 years ago

I am currently in the process of doing this.

ghost commented 6 years ago

Can you link the fixes when you got a chance? Would love to use it in my project.

rinux55 commented 6 years ago

In the meantime, FA 5.1 is out. It would be greatly appreciated if this version is added too :)

y0hami commented 6 years ago

Sorry it took me so long but I have finished the icon generation script and have made a repo for it https://github.com/hammy2899/fomantic-ui-icon-script. It can be used for FontAwesome free or pro.

I will also be added FontAwesome 5.2.0 to Fomantic in 2.5, you can keep up to date here https://github.com/hammy2899/Fomantic-UI/pull/79

Flipez commented 6 years ago

Will this be also integrated in semantic-ui?

y0hami commented 6 years ago

@Flipez I will try and get some time to do it today

Flipez commented 6 years ago

Thank you!

If the workflow for updating font awesome would be more clear I'd like to contribute aswell.

y0hami commented 6 years ago

@Flipez https://github.com/fomantic/icon-script

y0hami commented 6 years ago

This may take me a little longer because I will need to solve some conflicts and I need to make some adjustments to the docs.

colbin8r commented 5 years ago

Has this been put on the roadmap? This is the file that needs to be updated (along with the actual icon assets), right? https://github.com/Semantic-Org/Semantic-UI/blob/master/src/themes/default/elements/icon.overrides

zxlin commented 3 years ago

I decided to create a monkey patch for this. Useful to stop the prop types warning messages for legit font awesome icons in development while providing suggestions in case you mess up. Feel free to take a look if anyone needs this.
https://github.com/zxlin/semantic-ui-react-icons https://www.npmjs.com/package/semantic-ui-react-icons

felipenmoura commented 1 year ago

I just created this issue, related to the same thing. It is still using 5.0.8

https://github.com/Semantic-Org/Semantic-UI-React/issues/4441