search

Semantic-Org / Semantic-UI

Semantic is a UI component framework based around useful principles from natural language.
http://www.semantic-ui.com
MIT License
51.1k stars 4.94k forks source link

[Icon] - Icons in 2.4 are bolder than in Font Awesome 5 #6733

Open icruces opened 5 years ago

icruces commented 5 years ago

Steps

I am aware that the icon set was upgraded to Font Awesome 5 in latest releases, which made my application looks worse. I though it was due to the Font Awesome 5 redesign but then I tested both sets side by side and it seems that for some reason icons in Semantic UI (default theme) look quite different (uglier).

Expected Result

UI Semantic icons should look identical to Font Awesome 5 icons using the default theme.

Actual Result

Icons looks bolder

Version

2.4.2

Testcase

https://jsfiddle.net/tk17os4n/6

lubber-de commented 5 years ago

It's fixed in Fomantic UI already See https://jsfiddle.net/tymogjqw/

icruces commented 5 years ago

It's fixed in Fomantic UI already See https://jsfiddle.net/tymogjqw/

Thanks. I am not sure if I want to go that route. Is there any pull request for that fix so that I can try to fix it locally in the meantime?

GammaGames commented 5 years ago

It looks like @jlukic hasn't been active for a couple months, and I don't think anyone aside from him can merge requests. I wonder where he went this time 🤔
Anyway, the point of fomantic is

to continue active development of Semantic-UI and has the intent to be merged back into the master repository once active development can restart.

They actually have a ton of extra features and bugfixes (like this one) over regular semantic at this point.

icruces commented 5 years ago

Thanks, I will give it a go.

srissel commented 5 years ago

Can anyone please provide a link to the corresponding issue in Fomantic UI, in order one can fix the big in her local sUI setup manually?

lubber-de commented 5 years ago

@srissel This is the latest PR for FA 5.7 upgrade in Fomantic-UI https://github.com/fomantic/Fomantic-UI/pull/446

srissel commented 5 years ago

Many thanks, @lubber-de ! So it seems it wasn't an issue with Semantic UI, but rather with FontAwesome 5.6?

For our current release, unfortunately we cannot upgrade to Fomantic UI yet. Therefore we need to incorporate this fix manually into our current sUI integration.

y0hami commented 5 years ago

@srissel You can use our icon-script to help update your SUI builds 😉