search

Semantic-Org / Semantic-UI

Semantic is a UI component framework based around useful principles from natural language.
http://www.semantic-ui.com
MIT License
51.06k stars 4.95k forks source link

[modal] Second modal not showing if call "show" from onApprove of firrst modal #6741

Open dfsmirnov opened 5 years ago

dfsmirnov commented 5 years ago

Steps

  1. Create two modals.
    • Both with "allowMultiple: true".
    • First with "ok" action button
    • Add First::OnApprove with code to show second modal
  2. Show first modal
  3. Click "ok"

Expected Result

Second modal became visible. First modal is hidden.

Actual Result

Both modals are hidden

Version

2.4.2

Testcase

https://jsfiddle.net/dfsmirnov/fsmqk5v8/

rSensation commented 5 years ago

Seems like the issue is in hideModal method. Its module.transition's onStart callback checks if there is other active modals before hiding the dimmer but doesn't check for animating modals.

lubber-de commented 5 years ago

Fixed in Fomantic-UI by https://github.com/fomantic/Fomantic-UI/pull/605 See your adjusted jsfiddle here https://jsfiddle.net/wrzjh1gy