[Form] Resolved query 'set errors' leaving DOM element invisible.

Semantic-Org / Semantic-UI

Semantic is a UI component framework based around useful principles from natural language.

http://www.semantic-ui.com

MIT License

51.1k stars 4.95k forks source link

[Form] Resolved query 'set errors' leaving DOM element invisible. #6900

Closed akotulu closed 4 years ago

akotulu commented 4 years ago

Reported this issue with patch file, but it seems to be deleted by github or some other behind the scene force. Here is the fix. Currently adding errors to form via 'set errors' will leave the dom element invisible. Fix is to set the css class after error message.

y0hami commented 4 years ago

@akotulu This will most likely never be merged, its over 1 year now since last release of SUI (https://github.com/Semantic-Org/Semantic-UI/releases) take a look at Fomantic-UI the community fork.

lubber-de commented 4 years ago

I cannot seem to create a usecase where your described scenario is happening. See https://jsfiddle.net/uLrm0wcd/ add errors shows the errors just fine... 🤔 Could you please adjust the example, so we can see what exactly your code is going to fix? In Fomantic-UI 2.7.3 we fixed a similar issue for safari not showing the message via CSS by https://github.com/fomantic/Fomantic-UI/pull/558