search

Semantic-Org / Semantic-UI

Semantic is a UI component framework based around useful principles from natural language.
http://www.semantic-ui.com
MIT License
51.09k stars 4.95k forks source link

Outdated "Lato" font import #6973

Open rzubrycki opened 4 years ago

rzubrycki commented 4 years ago

Hello, there's outdated import for "lato" font from google api.

Expected Result

@import url('https://fonts.googleapis.com/css2?family=Lato@100&display=swap');

"display=swap'" this part is missing, after mdn: "If the font face is not loaded, any element attempting to use it must render a fallback font face. If the font face successfully loads during this period, it is used normally."

Actual Result

@import url('https://fonts.googleapis.com/css?family=Lato:400,700,400italic,700italic&subset=latin');

Version

"semantic-ui-css": "^2.4.1",

This turns into several issues with lighhouse score.

rzubrycki commented 4 years ago

Is semantic-ui maintained?

GammaGames commented 4 years ago

@rzubrycki The only maintainer that had permissions to merge with master hasn't been back since October 2018, the community created their own fork with many improvements and bugfixes over at https://github.com/fomantic/Fomantic-UI It's still active and getting updates

lubber-de commented 4 years ago

We prepared the google font api update to v2 by https://github.com/fomantic/Fomantic-UI/pull/1674 The display=swap was already implemented by fomantic since a few versions

codler commented 3 years ago

It is strange that Semantic-UI-React is still active but the core Semantic-UI is dead. I hope this will be fixed.

GammaGames commented 3 years ago

@codler looks like SUIR has some issues tagged with compatibility for FUI, the active fork of SUI