Semantic-Org / Semantic-UI

Semantic is a UI component framework based around useful principles from natural language.
http://www.semantic-ui.com
MIT License
51.09k stars 4.95k forks source link

"Ribbon" wrong "left" value #6991

Open oguzhansari opened 4 years ago

oguzhansari commented 4 years ago

Hello, I used "ribbon" in "card> image". "ribbon" slid too far to the left. I reviewed CSS. Minus value misspelled in "left".

Existing; .ui.card .image> .ui.ribbon.label, .ui.image> .ui.ribbon.label { left: calc (*--. 05rem - 1.2em); }

Must be; .ui.card .image> .ui.ribbon.label, .ui.image> .ui.ribbon.label { left: calc (*-. 05rem - 1.2em); }

lubber-de commented 4 years ago

The community fork Fomantic-UI already fixed this 2 years ago in 2.5.0 (it's actually +0.05em instead of -0.05em ( because - * - = + ) https://github.com/fomantic/Fomantic-UI/blob/0269a8213ac2ff438965c6a82503e7561d2024ae/dist/components/label.css#L434

oguzhansari commented 4 years ago

This is the first time I've heard of Fomantic-Ui :)