search

Semantic-Org / Semantic-UI

Semantic is a UI component framework based around useful principles from natural language.
http://www.semantic-ui.com
MIT License
51.09k stars 4.95k forks source link

[Icon] Fixed background issue when Icon is used as Labeled Icon for Button as loading one #7023

Closed flppv closed 1 year ago

flppv commented 3 years ago

Description

See my initial issue https://github.com/Semantic-Org/Semantic-UI-React/issues/4088

I moved icon-loading animation into :before element itself.

Testcase

Before: https://jsfiddle.net/afkm1v7w/ After: https://jsfiddle.net/t16y3wLk/ (I demonstrated my changes in temporary CSS override)

lubber-de commented 3 years ago

A similiar fix is already available in the community fork Fomantic-UI since 2.7.2 See your jsfiddle using fomantic here https://jsfiddle.net/lubber/wy3qLhk9/

flppv commented 3 years ago

@lubber-de does it mean that this fix shouldn't be done here in Semantic UI?

lubber-de commented 3 years ago

@flppv SUI still has this bug, so your PR is valid. However, look at all other PRs to get an idea if this will be merged into SUI any time soon ... I am just saying that the active community fork already took care about this specific bug almost 20 months ago. 😉

flppv commented 3 years ago

Frankly, I haven't heard about Fomantic earlier, as I am satisfied with Semantic UI. Then I've found a bug and decided that I can contribute into it's fix.

If there is an existing PR to fix that bug here, in SemanticUI, let me know and I'll close my one.

lubber-de commented 3 years ago

@flppv You are the first one who provided a fix for the mentioned issue here, so all fine, keep it open. And if you are otherwise satisfied with the current state of SUI then keep using it. 🙂

jlukic commented 1 year ago

This PR breaks regular regular usage of loading icon.

I've implemented this in 49b9cbf47 and updated the docs to include an example.