Semantic-Org / Semantic-UI

Semantic is a UI component framework based around useful principles from natural language.
http://www.semantic-ui.com
MIT License
51.07k stars 4.96k forks source link

remove extra semicolon #7089

Closed LucienLeMagicien closed 1 year ago

LucienLeMagicien commented 1 year ago

Webpack v5's CSS loader fails when seeing this double semicolon. The error looks something like:

 Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
TypeError: Cannot read property 'get' of undefined
    at /var/www/node_modules/webpack/lib/asset/AssetModulesPlugin.js:212:52
    [...]
error  in data:application/x-font-ttf;charset=utf-8;;base64,AAEAAAAOAIAAAwBgT1MvM[...]
Module build failed: UnhandledSchemeError: Reading from "data:application/x-font-ttf;charset=utf-8;;base64,AAEAAAAOAIAAAwBgT1MvM[...]" is not handled by plugins (Unhandled scheme).
Webpack supports "data:" and "file:" URIs by default.
You may need an additional plugin to handle "data:" URIs.

As @jlukic says in this comment, this should be the place to fix this. The contribution guide says to merge against next, but that branch is 32 commits behind so I'm not too sure. Please feel free to adapt.

If this ends up not being merged, or if it does not trigger the automated commits and release, I suppose the other way to fix this would be in the css parser used by webpack? Otherwise, workarounds can be found on the issues linked in the commit, namely:

This would close #7073 once the updated css is published.

jlukic commented 1 year ago

I've gone ahead and merged this, will release to npm most likely this weekend.

jlukic commented 1 year ago

Think resolved in 2.5.0