search

Semantic-Org / Semantic-UI

Semantic is a UI component framework based around useful principles from natural language.
http://www.semantic-ui.com
MIT License
51.07k stars 4.96k forks source link

Issue #7122 Burmese Flag correction #7123

Open syang0624 opened 9 months ago

syang0624 commented 9 months ago

Issue Titles

https://github.com/Semantic-Org/Semantic-UI/issues/7122

[Flag] - Shows the Flag of Taiwan when try to use Burmese Flag #7122

Description

Was reading the documentation here: https://react.semantic-ui.com/elements/flag/#types-flag

but realized that the main example uses the Taiwan flag but in the code, it says Myanmar

Testcase

Expected When using Myanmar flag:

Instead of Showing 🇹🇼 should show 🇲🇲 Result Currently shows 🇹🇼 when using the Myanmar flag

syang0624 commented 9 months ago

Most of the add/deletion is based on the rc settings from the original library to just make css prettier.

However, the key update here is: SemanticUI was showing 🇹🇼 when the user wanted a Burmese flag. It should show 🇲🇲

Fixed with this PR!

OTonGitHub commented 2 months ago

is the project abandoned?

syang0624 commented 2 months ago

is the project abandoned?

honestly I am not sure. the PR was approved last December, but no one merged it.