Closed kittaakos closed 3 years ago
The reference to DataSource in JenaBasedSadlInferenceProcessor was unused, removed and pushed update. That doesn't really address the issue. I'm using Java 8 and javax.activation.DataSource is in the JRE System Library in rt.jar. I believe that in Java 11 it is in a different location. I built with Java 11 on my home Linux machine a few days ago and don't remember exactly what I did but it had to do with making it found in its new location. You may also find #526 of interest and if you have any insights please share. Jena 3.16 uses log4j v2 while Eclipse 2020-03 appears to be using log4j v1. I could not get logging to work as expected and I think that's the reason.
I'm using Java 8
I can confirm, it works with Java 8.
javax.activation.DataSource is in the JRE System Library in rt.jar. I believe that in Java 11 it is in a different location
It used to work with Java 9+ (including 11). See here.
So I could build it with Maven from a terminal, but I cannot import it into Eclipse:
.project
files are not generated,I already set the target platform and I also reran the MWE2 workflow; it did not help. How do you import the project after a fresh Git clone into Eclipse? Thank you!
I've pushed commit aac30671 which fixes the Java 11 compilation error, but there are more left. Since JenaBasedSadlInferenceProcessor.java uses javax.activation.DataSource indirectly due to calling result.setDerivations(getInitializedReasoner().getDerivations()), we must add javax.activation to com.ge.research.sadl.jena's MANIFEST.MF. These calls (setDerivations/getDerivations) were added to SADL after 3.4.0 was tagged.
Here're some new Java 11 compilation errors (now in com.ge.research.sadl.ide instead of com.ge.research.sadl.jena). @crapo and @kittaakos, I hope you can fix them since I'm not that familiar with Xtend code.
[INFO] --- xtend-maven-plugin:2.21.0:compile (default) @ com.ge.research.sadl.ide ---
[ERROR]
ERROR: SADLIdeModule.xtend - /home/interran/CASE/sadlos2/sadl3/com.ge.research.sadl.parent/com.ge.research.sadl.ide/src/com/ge/research/sadl/ide/SADLIdeModule.xtend
21: com.ge.research.sadl.ide.contentassist.antlr.lexer.jflex.JFlexBasedInternalSADLLexer cannot be resolved to a type.
[ERROR]
ERROR: SADLIdeModule.xtend - /home/interran/CASE/sadlos2/sadl3/com.ge.research.sadl.parent/com.ge.research.sadl.ide/src/com/ge/research/sadl/ide/SADLIdeModule.xtend
57: AbstractSADLIdeModule cannot be resolved to a type.
[ERROR]
ERROR: SADLIdeModule.xtend - /home/interran/CASE/sadlos2/sadl3/com.ge.research.sadl.parent/com.ge.research.sadl.ide/src/com/ge/research/sadl/ide/SADLIdeModule.xtend
60: The method or field JFlexBasedInternalSADLLexer is undefined
[ERROR]
ERROR: SADLIdeModule.xtend - /home/interran/CASE/sadlos2/sadl3/com.ge.research.sadl.parent/com.ge.research.sadl.ide/src/com/ge/research/sadl/ide/SADLIdeModule.xtend
57: Superclass must be a class
[ERROR]
ERROR: SADLIdeModule.xtend - /home/interran/CASE/sadlos2/sadl3/com.ge.research.sadl.parent/com.ge.research.sadl.ide/src/com/ge/research/sadl/ide/SADLIdeModule.xtend
59: The method configureContentAssistLexer(Binder) of type SADLIdeModule must override a superclass method.
[ERROR]
ERROR: SADLIdeModule.xtend - /home/interran/CASE/sadlos2/sadl3/com.ge.research.sadl.parent/com.ge.research.sadl.ide/src/com/ge/research/sadl/ide/SADLIdeModule.xtend
115: The method bindIRenameService2() of type SADLIdeModule must override a superclass method.
[ERROR]
ERROR: SADLIdeSetup.xtend - /home/interran/CASE/sadlos2/sadl3/com.ge.research.sadl.parent/com.ge.research.sadl.ide/src/com/ge/research/sadl/ide/SADLIdeSetup.xtend
It took a while--my laptop is slow and I had proxy issues--but I did succeed in building after pulling @tuxji 's commit. I followed the instructions at http://semanticapplicationdesignlanguage.github.io/sadl/developer/Sadl3BuildInstructions.html quite exactly with a freshly cloned repo, a new installation of OpenJDK 11.0.04, a new installation of Eclipse for Java Developers 2020-03, and a new workspace. When I finished the last step, Maven Update Projects..., my errors were all gone. I ran as Eclipse application and got a functioning SADL IDE.
I followed the instructions at http://semanticapplicationdesignlanguage.github.io/sadl/developer/Sadl3BuildInstructions.html
Me too. I started from scratch from my personal mac, and it worked now. Thank you so much!
@crapo, I might have missed a step, but I could not build the project from a fresh Git clone. Steps to reproduce:
Have the build steps changed? What are the steps I have to do to be able to clone the project, build it, and import it into Eclipse? Thank you!
Error:
Java version:
Full console output:
Required for #523