search

SemanticApplicationDesignLanguage / sadl

Semantic Application Design Language (SADL) Open Source Code
http://semanticapplicationdesignlanguage.github.io/sadl/
Eclipse Public License 1.0
30 stars 12 forks source link

Sub-property syntax question #594

Closed AbhaMoitra closed 3 years ago

AbhaMoitra commented 3 years ago

@crapo : Is the following allowed?

image

I ran into this when converting https://github.com/yzhao30/PATO-ROSE/blob/master/ontology/c.owl to a SADL file. In this conversion, there were just a few errors and I am trying to understand them.

crapo commented 3 years ago

@AbhaMoitra , these constructs generate no errors and the OWL translation looks to me to be correct. In that sense I think they are "allowed". Presumably this is not one of the "few errors" you encountered....

AbhaMoitra commented 3 years ago

@crapo -it is the root cause of the error I see in c.sadl. In a small snippet, when I use subprop1, it is not viewed as a property. So I have

image

And the error says 'subprop1' is not a property

crapo commented 3 years ago

@AbhaMoitra , I encourage you to use Discussions rather than Issues for non-issues, which this seems to me to be. When you are satisfied with the dialog please close this issue.

crapo commented 3 years ago

This is a slightly different construct than in your first post. I do see the error now. Will look into it. I failed to notice the coloring of subprop1 in your first post.

AbhaMoitra commented 3 years ago

@crapo : I will use Discussion in the future. Thanks.

crapo commented 3 years ago

@AbhaMoitra , I misunderstood. Because I didn't notice the color error (subprop1 colored as class, not property) I thought this was just a question, not the reporting of an issue. This is where it belongs as it is an issue.

crapo commented 3 years ago

@AbhaMoitra , I think you will get notification that PR #595 fixes this issue. @tuxji , where is the zip that is automatically created that Abha could use if she wanted this fix immediately? If I understood, there is an update zip automatically created when ?tests pass? on merge to development?

tuxji commented 3 years ago

@crapo Yes, SADL's GitHub Actions workflow has automatically created an update zip twice: 1) while checking that the pull request builds successfully (SADL Continuous Integration Workflow #18), and 2) after merging the pull request into the main branch (SADL Continuous Integration Workflow #19). Either you or Abha can find the latest update zip anytime by drilling into the Actions tab and clicking on the most recent successfully completed run in the list of workflow results.

crapo commented 3 years ago

Thanks @tuxji ! I've add instructions on installing the latest bleeding edge as a note in the installation instructions.