search

SemanticMediaWiki / Mermaid

Provides a parser function to generate diagrams and flowcharts with the help of the mermaid script language
https://www.mediawiki.org/wiki/Extension:Mermaid
Other
36 stars 23 forks source link

Improve ID entropy, refs #12 #13

Closed mwjames closed 6 years ago

mwjames commented 6 years ago

Fixes #12

mwjames commented 6 years ago

...PHP Fatal error: Call to undefined function Mermaid\random_int() in /home/travis/build/SemanticMediaWiki/mw/extensions/Mermaid/src/MermaidParserFunction.php on line 56

random_int only exists since PHP 7

mwjames commented 6 years ago

@kghbln If it weren't for the tests, I would have totally missed that.

kghbln commented 6 years ago

@mwjames No need to convince me. I am already with you. :) Should I move this out to the public next week as 1.0.1?

mwjames commented 6 years ago

Should I move this out to the public next week as 1.0.1?

Fine with me.

foretix commented 6 years ago

I made a test with 335dc87 commit and it works fine.

Thank you both for support.