search

SemanticMediaWiki / Mermaid

Provides a parser function to generate diagrams and flowcharts with the help of the mermaid script language
https://www.mediawiki.org/wiki/Extension:Mermaid
Other
36 stars 24 forks source link

Fix "the the" typo in file dagre-d3.min.js #18

Closed kizule closed 6 years ago

mwjames commented 6 years ago

While I see no problem to merge this change, you have to be aware that those are come from upstream meaning that as soon as we fetch a new version from upstream (such as D3) it is most likely that those issues persists as long as those aren't fixed in the original repository.

kizule commented 6 years ago

Should I close this PR than?

kghbln commented 6 years ago

Should I close this PR than?

No not necessarily, you will just have to create another one upstream.

kizule commented 6 years ago

I did not understand quite well.

kghbln commented 6 years ago

I did not understand quite well.

In order to prevent this pull from being completely useless you also need to create another pull for the upstream library.

kizule commented 6 years ago

you also need to create another pull for the upstream library.

In which repository?

kghbln commented 6 years ago

In which repository?

https://www.google.com/search?q=d3+library&gws_rd=ssl --> https://github.com/d3/d3

kizule commented 6 years ago

I can't find nothing there.

kghbln commented 6 years ago

I can't find nothing there.

If you do not find the typo in the lib they may as well have fixed it in the meantime. This also means that it is not necessary to fix the typo here since the next time the lib is pulled in the fix will be pulled in too. :)