search

SemanticMediaWiki / Mermaid

Provides a parser function to generate diagrams and flowcharts with the help of the mermaid script language
https://www.mediawiki.org/wiki/Extension:Mermaid
Other
36 stars 24 forks source link

mediawiki.api.parse is deprecated #21

Closed Krinkle closed 4 years ago

Krinkle commented 5 years ago

FYI:

The mw.Api parse method(s) are part of the mediawiki.api module bundle as of MW 1.31 MW 1.32, leaving mediawiki.api.parse as deprecated alias, to be removed in MW 1.33.

(Found via Codesearch.)

kghbln commented 5 years ago

Thanks for reporting!

kghbln commented 5 years ago

We need to revert this one.

kghbln commented 5 years ago

@JeroenDeDauw This is not just a bloody joke, this appears to be a bloody mess to, just because we would like to support latest MW LTS and consecutive versions. So reverting and adding https://github.com/SemanticMediaWiki/SemanticMediaWiki/commit/580c75114fc9f5c896bafd705df8145eb48ba689 should help? Could you have a peep it this commit also added here will work for the extension? Thanks a ton!

JeroenDeDauw commented 5 years ago

I'm not maintaining this extension. Perhaps only supporting what can easily be supported is the most pragmatic thing to do here.

kghbln commented 5 years ago

I'm not maintaining this extension.

I am fully aware here. I was more seeking for input from someone who is more proficient in PHP than I am.

kghbln commented 5 years ago

So we just pass down this utter disaster from MW to the server admins. Fine with me. I am actually wondering why I still somehow tried to care.

kghbln commented 5 years ago

Fine with me.

Actually this is not fine. This is bullshit at its best to put it in nice words. I currently fail to accept that we are unable to support wikis outside in a sane manner.

hexmode commented 5 years ago

I currently fail to accept that we are unable to support wikis outside in a sane manner.

@kghbln I just discovered this. Could you help me understand what the problem is? I do not want to lose you or this community.

kghbln commented 4 years ago

@kghbln I just discovered this. Could you help me understand what the problem is? I do not want to lose you or this community.

I did not see this before. Sorry and thank you for trying to make a difference. The issue basically was that obviously quite some people do not understand the reason for LTS releases. In these cases the strategy is to let wiki admins figure out what to do.

I personally would have loved to have a version to support both the preceding and the following LTS branch for better experience. Tough titties.