search

SemanticMediaWiki / Mermaid

Provides a parser function to generate diagrams and flowcharts with the help of the mermaid script language
https://www.mediawiki.org/wiki/Extension:Mermaid
Other
36 stars 24 forks source link

Remove check for MediaWiki environment from setup file #51

Closed mszabo-wikia closed 4 years ago

mszabo-wikia commented 4 years ago

This PR addresses or contains:

Currently, Mermaid autoloads its setup file via Composer's autoloader and exits if it does not detect a MediaWiki environment. This prevents developers from executing tools also installed via composer such as the phpunit binary, or phpcs/phpcbf/phan etc., as Mermaid will immediately exit the process. As a fix, remove the environment check; this is also consistent with how Semantic MediaWiki itself behaves since https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/1732.

This PR includes:

mszabo-wikia commented 4 years ago

cc @kghbln @mwjames

JeroenDeDauw commented 4 years ago

Should be fixed by https://github.com/SemanticMediaWiki/Mermaid/pull/47 already

mszabo-wikia commented 4 years ago

Awesome, thanks!